Adding to the index of a bare repository.#131
Merged
Byron merged 2 commits intogitpython-developers:masterfrom Nov 17, 2014
moshevds:master
Merged
Adding to the index of a bare repository.#131Byron merged 2 commits intogitpython-developers:masterfrom moshevds:master
Byron merged 2 commits intogitpython-developers:masterfrom
moshevds:master
Conversation
Adding using a path should still require a non-bare repository.
Adding to a bare repository is now possible because @git_working_dir is only used on the relevant methods.
Member
|
Thank you - I will backport the fix to branch 0.3. |
Member
There was a problem hiding this comment.
The path_rewriter case is not handled properly anymore. Will look into this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using add() on the index of a bare repository is currently not possible. There seems to be no reason for this however, as the relevant code is implemented without touching the working tree directory at all.
This pull request mostly moves the working tree specific code to separate methods. This way @git_working_dir is only used when actually needed, and this way add() works on bare repositories.
One additional problem that might need some attention and/or fixing is the "rw_bare_repo._working_tree_dir = None" line in the test. I'm not exactly sure why GitPython still thinks there is a valid working directory after cloning to a bare copy.